Hi Marek, On Mon, Jun 17, 2024 at 05:26:02PM +0200, Marek Behún wrote: > Add support for true board poweroff (MCU can disable all unnecessary > voltage regulators) and wakeup at a specified time, implemented via a > RTC driver so that the rtcwake utility can be used to configure it. > > Signed-off-by: Marek Behún <kabel@xxxxxxxxxx> > Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> > Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx> ... > diff --git a/drivers/platform/cznic/Kconfig b/drivers/platform/cznic/Kconfig > index d95e7c83c7ae..c1e719235517 100644 > --- a/drivers/platform/cznic/Kconfig > +++ b/drivers/platform/cznic/Kconfig > @@ -18,10 +18,14 @@ config TURRIS_OMNIA_MCU > depends on I2C > select GPIOLIB > select GPIOLIB_IRQCHIP > + select RTC_CLASS > help > Say Y here to add support for the features implemented by the > microcontroller on the CZ.NIC's Turris Omnia SOHO router. > The features include: > + - board poweroff into true low power mode (with voltage regulators > + disabled) and the ability to configure wake up from this mode (via > + rtcwake) > - GPIO pins > - to get front button press events (the front button can be > configured either to generate press events to the CPU or to change I am seeing the following Kconfig warning from ARCH=s390 allmodconfig: WARNING: unmet direct dependencies detected for RTC_CLASS Depends on [n]: !S390 [=y] Selected by [m]: - TURRIS_OMNIA_MCU [=m] && CZNIC_PLATFORMS [=y] && (MACH_ARMADA_38X || COMPILE_TEST [=y]) && I2C [=m] && OF [=y] && WATCHDOG [=y] because of: menuconfig RTC_CLASS bool "Real Time Clock" default n depends on !S390 which appears to have ultimately come from commit 9556fb73edfc ("[S390] Kconfig: unwanted menus for s390."). No other driver appears to unconditionally select this (I only see it selected within arch/*/Kconfig), so it does not look like this has come up before. Should s390 be excluded from the COMPILE_TEST dependency? Cheers, Nathan