> Subject: Re: [PATCH v5 0/7] firmware: support i.MX95 SCMI BBM/MISC > Extenstion > > On 11/07/2024 15:05:42+0100, Cristian Marussi wrote: > > On Fri, Jun 21, 2024 at 03:04:35PM +0800, Peng Fan (OSS) wrote: > > > i.MX95 System Manager Firmware source: > > > > ed=0 > > > To generate html from the repo: make html > > > > > > > Hi Peng, > > > > thanks for upstreaming this Vendor protocol. > > The question being when are they going to reuse the protocols, we > already have two just from nxp: > > rtc-nxp-bbnsm.c This is mmio register access driver > rtc-imx-sc.c This is i.MX8 SCFW based, at that time, SCMI was not used. The current patchset is use SCMI protocol. I hope this is generic for Future i.MX SCMI based RTC. Thanks, Peng. > > > > > > > LGTM, beside minor nitpicks I mentioned. > > > > Please run checkpatch.pl --strict on series before next rebase, > > though, that I spotted a few minor not-so-stylish things :D > > > > Thanks, > > Cristian > > -- > Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and > Kernel engineering > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F > bootlin.com%2F&data=05%7C02%7Cpeng.fan%40nxp.com%7Cd55f2af > 62d464d6448a108dca1e35007%7C686ea1d3bc2b4c6fa92cd99c5c301 > 635%7C0%7C0%7C638563244865575023%7CUnknown%7CTWFpbGZ > sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJX > VCI6Mn0%3D%7C0%7C%7C%7C&sdata=Y%2Fb59hmu7EmIQx6KMXCx > P2X97h0bZiHqawOdNeoVPhc%3D&reserved=0