On 11/07/2024 15:21, Mark Brown wrote:
On Thu, Jul 11, 2024 at 03:05:01PM +0100, Ian Abbott wrote:
I think the devicetree node for the RTC device ought to be setting
`spi-cs-high` but cannot do so at the moment because the driver clobbers it.
Specifying spi-cs-high in the device tree should almost always be
redundant or a mistake, if the device needs a high chip select then we
already know that from the compatible. The property is adding nothing
but potential confusion, in the normal course of affairs the driver
should just specify the configuration it needs for the bus.
So `spi->mode |= SPI_CS_HIGH;` is safer than `spi->mode ^= SPI_CS_HIGH;`?
Regarding `spi-cs-high` in the device tree, what about the compatibility
table for `spi-cs-high` and `cs-gpio` active level in
"Documentation/devicetree/bindings/spi/spi-controller.yaml"?
--
-=( Ian Abbott <abbotti@xxxxxxxxx> || MEV Ltd. is a company )=-
-=( registered in England & Wales. Regd. number: 02862268. )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-
