On 17/06/2024 10:25, CL Wang wrote: > Add YAML bindings for Andes atcrtc100 RTC. A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > > Signed-off-by: CL Wang <cl634@xxxxxxxxxxxxx> > --- > .../bindings/rtc/andes,atcrtc100-rtc.yaml | 39 +++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/andes,atcrtc100-rtc.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/andes,atcrtc100-rtc.yaml b/Documentation/devicetree/bindings/rtc/andes,atcrtc100-rtc.yaml > new file mode 100644 > index 000000000000..86cecb30c889 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/andes,atcrtc100-rtc.yaml Use compatible as filename. > @@ -0,0 +1,39 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/andes,atcrtc100-rtc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Andes, ATCRTC100 on-SoC RTC > + > +allOf: > + - $ref: rtc.yaml# allOf goes after maintainers. > + > +maintainers: > + - CL Wang <cl634@xxxxxxxxxxxxx> > + > +properties: > + compatible: > + enum: > + - andestech,atcrtc100 > + > + reg: > + maxItems: 1 > + > + interrupts: > + minItems: 2 This must be specific. Describe the items instead (items: with - description: for each). > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false Instead: unevaluatedProperties: false Best regards, Krzysztof
