On 15.06.2024 15:17, Conor Dooley wrote: > On Fri, Jun 14, 2024 at 10:19:22AM +0300, Claudiu wrote: >> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> >> >> The VBATTB IP of the Renesas RZ/G3S SoC controls the clock that feeds >> the RTC and the tamper detector. Add documentation for the VBATTB clock >> driver. >> >> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> >> --- >> .../clock/renesas,rzg3s-vbattb-clk.yaml | 90 +++++++++++++++++++ >> 1 file changed, 90 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/renesas,rzg3s-vbattb-clk.yaml >> >> diff --git a/Documentation/devicetree/bindings/clock/renesas,rzg3s-vbattb-clk.yaml b/Documentation/devicetree/bindings/clock/renesas,rzg3s-vbattb-clk.yaml >> new file mode 100644 >> index 000000000000..ef52a0c0f874 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/renesas,rzg3s-vbattb-clk.yaml >> @@ -0,0 +1,90 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/clock/renesas,rzg3s-vbattb-clk.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Renesas VBATTB clock >> + >> +maintainers: >> + - Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> >> + >> +description: >> + Renesas VBATTB module is an always on powered module (backed by battery) which >> + generates a clock (VBATTCLK). This clocks feeds the RTC and the tamper detector >> + modules. >> + >> +properties: >> + compatible: >> + const: renesas,rzg3s-vbattb-clk >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + items: >> + - description: VBATTB module clock >> + - description: VBATTB input xtal >> + >> + clock-names: >> + items: >> + - const: bclk >> + - const: vbattb_xtal >> + >> + '#clock-cells': >> + const: 0 >> + >> + power-domains: >> + maxItems: 1 >> + >> + renesas,vbattb-load-nanofarads: >> + description: load capacitance of the on board xtal >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + enum: [ 4000, 7000, 9000, 12500 ] >> + >> + renesas,vbattb-osc-bypass: >> + description: set when external clock is connected to RTXOUT pin >> + type: boolean > > When you say "external clock", is that an input or an output? I took that statement from the HW manual. As of the HW manual [1], table 42.2, that would be an input. [1] https://www.renesas.com/us/en/products/microcontrollers-microprocessors/rz-mpus/rzg3s-general-purpose-microprocessors-single-core-arm-cortex-a55-11-ghz-cpu-and-dual-core-cortex-m33-250