On Wed, Jun 5, 2024 at 7:19 PM Marek Behún <kabel@xxxxxxxxxx> wrote: > > Add support for true board poweroff (MCU can disable all unnecessary > voltage regulators) and wakeup at a specified time, implemented via a > RTC driver so that the rtcwake utility can be used to configure it. ... > +#include <linux/crc32.h> > +#include <linux/delay.h> + device.h + err.h > +#include <linux/i2c.h> + kstrtox.h > +#include <linux/reboot.h> > +#include <linux/rtc.h> > +#include <linux/sysfs.h> > +#include <linux/turris-omnia-mcu-interface.h> As per other patches. > +#include <linux/types.h> > + > +#include "turris-omnia-mcu.h" ... > + struct device *dev = kobj_to_dev(kobj); Is this declared in device.h or elsewhere? ... > +#include <linux/rtc.h> I don't see you need it. Just struct rtc_device; should suffice. > #include <linux/types.h> > #include <linux/workqueue.h> > #include <asm/byteorder.h> > +#include <asm/unaligned.h> ... With the above being addressed, LGTM, FWIW, Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx> -- With Best Regards, Andy Shevchenko
