Re: [PATCH v10 2/9] platform: cznic: Add preliminary support for Turris Omnia MCU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 10, 2024 at 04:41:20PM +0300, Andy Shevchenko wrote:
> On Fri, May 10, 2024 at 1:18 PM Marek Behún <kabel@xxxxxxxxxx> wrote:
> >
> > Add the basic skeleton for a new platform driver for the microcontroller
> > found on the Turris Omnia board.
> 
> ...
> 
> > +       err = omnia_cmd_read(client, cmd, &reply, sizeof(reply));
> > +       if (!err)
> > +               *dst = le32_to_cpu(reply);
> > +
> > +       return err;
> 
> Introduced here and "fixed" in the next patch. Something wrong with
> rebasing / squashing?
> 
> You will need a v11 anyway. And you have now much more time for it,
> don't forget to update the kernel version and date in the ABI
> documentation.

It would seem so. I will send v11 also with the GPIO changes (to use
__set_bit() and friends).

Marek




[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux