Re: [PATCH 2/2] rtc: rx8111: handle VLOW flag

[Waqar Hameed <waqar.hameed@xxxxxxxx>]

On Wed, Apr 17, 2024 at 21:19 +0200 alexandre.belloni@xxxxxxxxxxx wrote:

> From: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
>
> Allow userspace to get battery status information and be able to warn when
> battery is low and has to be replaced.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> ---
>  drivers/rtc/rtc-rx8111.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/rtc/rtc-rx8111.c b/drivers/rtc/rtc-rx8111.c
> index 4a35bd921b33..8450d9f0b566 100644
> --- a/drivers/rtc/rtc-rx8111.c
> +++ b/drivers/rtc/rtc-rx8111.c
> @@ -95,6 +95,9 @@ enum rx8111_regfield {
>  	RX8111_REGF_INIEN,
>  	RX8111_REGF_CHGEN,
>  
> +	/* RX8111_REG_STATUS_MON. */
> +	RX8111_REGF_VLOW,
> +
>  	/* Sentinel value. */
>  	RX8111_REGF_MAX
>  };
> @@ -129,6 +132,8 @@ static const struct reg_field rx8111_regfields[] = {
>  	[RX8111_REGF_SWSEL1] = REG_FIELD(RX8111_REG_PWR_SWITCH_CTRL, 3, 3),
>  	[RX8111_REGF_INIEN]  = REG_FIELD(RX8111_REG_PWR_SWITCH_CTRL, 6, 6),
>  	[RX8111_REGF_CHGEN]  = REG_FIELD(RX8111_REG_PWR_SWITCH_CTRL, 7, 7),
> +
> +	[RX8111_REGF_VLOW]  = REG_FIELD(RX8111_REG_STATUS_MON, 1, 1),
>  };
>  
>  static const struct regmap_config rx8111_regmap_config = {
> @@ -276,6 +281,13 @@ static int rx8111_ioctl(struct device *dev, unsigned int cmd, unsigned long arg)
>  
>  		vlval = regval ? RTC_VL_DATA_INVALID : 0;
>  
> +		ret = regmap_field_read(data->regfields[RX8111_REGF_VLOW],
> +					&regval);
> +		if (ret)
> +			return ret;
> +
> +		vlval |= regval ? RTC_VL_BACKUP_LOW : 0;
> +
>  		return put_user(vlval, (typeof(vlval) __user *)arg);
>  	default:
>  		return -ENOIOCTLCMD;

Looks good to me!

Tested-by: Waqar Hameed <waqar.hameed@xxxxxxxx>
Reviewed-by: Waqar Hameed <waqar.hameed@xxxxxxxx>