On Fri, Apr 12, 2024 at 11:17:38AM +0200, Krzysztof Kozlowski wrote: > On 12/04/2024 10:01, wefu@xxxxxxxxxx wrote: > > From: Wei Fu <wefu@xxxxxxxxxx> > > > > This patch add "snps,dw-apb-rtc" into the "compatible". > > > Please do not use "This commit/patch/change", but imperative mood. See > longer explanation here: > https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > This we see from the patch. Say what hardware are you adding? The compatible, unless I misread the patchset, isn't actually documented either, only the new property is. > > Please run scripts/checkpatch.pl and fix reported warnings. Then please > run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. > Some warnings can be ignored, especially from --strict run, but the code > here looks like it needs a fix. Feel free to get in touch if the warning > is not clear. > > > Best regards, > Krzysztof >
Attachment:
signature.asc
Description: PGP signature
