Hi Rob, On Tue, Mar 05, 2024 at 07:20:21AM -0600, Rob Herring wrote: > On Tue, 05 Mar 2024 02:42:17 +0200, Laurent Pinchart wrote: > > Hello, > > > > This small patch series is a drive-by addition of the Compulab > > SB-UCM-iMX8MPLUS to the Linux kernel device tree sources. While porting > > the device tree from the Compulab BSP kernel to mainline, I thought I > > could as well mainline it, along with related conversion of text DT > > bindings to YAML. > > > > The SB-UCM-iMX8MPLUS is a carrier board designed as a reference to > > evaluate the Compulab UCM-iMX8MPLUS SoM. The SoM integrates the bare > > minimal peripherals (DRAM, eMMC, ethernet PHY, EEPROM and RTC), while > > the carrier board includes a much wider range of peripherals. I have > > only enabled support for the ones I am interested in, or, as a strech > > goal, the ones I could easily test. > > > > The first patch in the series adds compatible strings for the SoM and > > the board to the ARM FSL bindings. The next patch then converts text DT > > bindings to a YAML schema for the RTC present on the SoM. Finally, the > > last two patches add DT sources for the SoM and the carrier board. > > > > Please see individual patches for details. > > > > I have checked the validity of the bindings and the device tree sources. > > The only warnings in the DT sources are due to issues in imx8mp.dtsi. > > > > Laurent Pinchart (4): > > dt-bindings: arm: fsl: Add Compulab SB-UCM-iMX8MPLUS carrier board > > dt-bindings: rtc: abx80x: Convert text bindings to YAML > > arm64: dts: freescale: Add device tree for Compulab UCM-iMX8M-Plus > > arm64: dts: freescale: Add device tree for Compulab SB-UCM-iMX8MPLUS > > > > .../devicetree/bindings/arm/fsl.yaml | 6 + > > .../bindings/rtc/abracon,abx80x.txt | 31 -- > > .../bindings/rtc/abracon,abx80x.yaml | 89 +++++ > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > .../boot/dts/freescale/imx8mp-sb-ucm.dts | 284 ++++++++++++++++ > > arch/arm64/boot/dts/freescale/imx8mp-ucm.dtsi | 309 ++++++++++++++++++ > > 6 files changed, 689 insertions(+), 31 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/rtc/abracon,abx80x.txt > > create mode 100644 Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-ucm.dtsi > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y freescale/imx8mp-sb-ucm.dtb' for 20240305004222.622-1-laurent.pinchart@xxxxxxxxxxxxxxxx: > > Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:68.1-10 Label or path hdmi_pvi not found > Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:72.1-9 Label or path hdmi_tx not found > Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:86.1-13 Label or path hdmi_tx_phy not found > Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:208.1-8 Label or path lcdif3 not found I forgot to mention in the cover letter that this depends on i.MX8MP HDMI integration in DT that is currently pending. As it's not in linux-next yet, I'll send a v2 that splits HDMI support in a separate patch. Depending on when the HDMI integration gets merged, the base SB-UCM support can go in by itself or with HDMI support in v6.10. > FATAL ERROR: Syntax error parsing input tree > make[3]: *** [scripts/Makefile.lib:419: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dtb] Error 1 > make[2]: *** [scripts/Makefile.build:481: arch/arm64/boot/dts/freescale] Error 2 > make[2]: Target 'arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dtb' not remade because of errors. > make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1385: freescale/imx8mp-sb-ucm.dtb] Error 2 > make: *** [Makefile:240: __sub-make] Error 2 > make: Target 'freescale/imx8mp-sb-ucm.dtb' not remade because of errors. -- Regards, Laurent Pinchart