On Wed, 17 Jan 2024 10:54:16 -0700, Nathan Chancellor wrote:
> Clang warns (or errors with CONFIG_WERROR=y):
>
> drivers/rtc/rtc-max31335.c:211:36: error: use of logical '||' with constant operand [-Werror,-Wconstant-logical-operand]
> 211 | if (reg == MAX31335_TEMP_DATA_MSB || MAX31335_TEMP_DATA_LSB)
> | ^ ~~~~~~~~~~~~~~~~~~~~~~
> drivers/rtc/rtc-max31335.c:211:36: note: use '|' for a bitwise operation
> 211 | if (reg == MAX31335_TEMP_DATA_MSB || MAX31335_TEMP_DATA_LSB)
> | ^~
> | |
> 1 error generated.
>
> [...]
Applied, thanks!
[1/1] rtc: max31335: Fix comparison in max31335_volatile_reg()
https://git.kernel.org/abelloni/c/dd7fe5d9fd6a
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
