Hi Alexandre Belloni, > -----Original Message----- > From: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> > Sent: Tuesday, December 19, 2023 11:50 PM > Subject: Re: [PATCH 3/6] rtc: da9063: Use dev_err_probe() > > On 01/12/2023 16:40:25+0000, Biju Das wrote: > > > RTC_FEATURE_ALARM is what you should clear and you have to fallback > > > to the irq is not present case. > > > > > > Ok,Will update Patch#3 with clearing "RTC_FEATURE_ALARM" as the > > fallback for the irqhandler error case > > > > On patch#1, I will clear both RTC_FEATURE_ALARM" and > > "RTC_FEATURE_UPDATE_INTERRUPT", > > > > as with just clearing "RTC_FEATURE_ALARM", I get below error. > > > > root@smarc-rzg2ul:~# date -s "2023-08-06 19:30:00" > > Sun Aug 6 19:30:00 UTC 2023 > > root@smarc-rzg2ul:~# hwclock -w > > root@smarc-rzg2ul:~# hwclock -r > > hwclock: select() to /dev/rtc0 to wait for clock tick timed out > > root@smarc-rzg2ul:~# > > > > > > I can't believe this is true because the rtc core code will take the same > path when RTC_FEATURE_ALARM or RTC_FEATURE_UPDATE_INTERRUPT is > cleared: > > > RTC_FEATURE_UPDATE_INTERRUPT must be cleared only when RTC_FEATURE_ALARM > is set. I rechecked this with latest next and it is working with clearing RTC_FEATURE_ALARM. I will send v3 with this change. root@smarc-rzg2ul:~# date -s "2023-08-06 19:30:00" Sun Aug 6 19:30:00 UTC 2023 root@smarc-rzg2ul:~# hwclock -w root@smarc-rzg2ul:~# hwclock -r 2023-08-06 19:30:11.664350+00:00 root@smarc-rzg2ul:~# Cheers, Biju
