// resending - first message was rejected as HTML-formatted
W dniu 28.11.2023 o 06:36, Mario Limonciello pisze:
> The UIP timeout is hardcoded to 10ms for all RTC reads, but in some
> contexts this might not be enough time. Add a timeout parameter to
> mc146818_get_time() and mc146818_get_time_callback().
>
> If UIP timeout is configured by caller to be >=100 ms and a call
> takes this long, log a warning.
>
> Make all callers use 10ms to ensure no functional changes.
>
> Cc: stable@xxxxxxxxxxxxxxx # 6.1.y
> Fixes: ec5895c0f2d8 ("rtc: mc146818-lib: extract mc146818_avoid_UIP")
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> ---
> v3->v4:
> * Change label
> * Logic adjustment for for loop
> * Fix pr_warn variable
> v2->v3:
> * Logic adjustments
> * Clarify warning message
> v1->v2:
> * Add a warning if 100ms or more
> * Add stable and fixes tags
>
Hello,
Tested-by: Mateusz Jończyk <mat.jonczyk@xxxxx>
Reviewed-by: Mateusz Jończyk <mat.jonczyk@xxxxx>
Acked-by: Mateusz Jończyk <mat.jonczyk@xxxxx>
I have retested the whole series on 2 computers
(not affected by the bug, resp. with / without HPET IRQ emulation).
Thank you for this patch series.
@Alexandre would it be possible to submit it for Linux 6.7?
There were several problem reports and it is marked for stable.
Greetings,
Mateusz
