On Wed, 8 Nov 2023 11:43:36 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Acked-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../bindings/iio/adc/samsung,exynos-adc.yaml | 29 +++++++++++-------- > 1 file changed, 17 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > index 582d0a03b814..4e40f6bed5db 100644 > --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > @@ -11,18 +11,23 @@ maintainers: > > properties: > compatible: > - enum: > - - samsung,exynos-adc-v1 # Exynos5250 > - - samsung,exynos-adc-v2 > - - samsung,exynos3250-adc > - - samsung,exynos4212-adc # Exynos4212 and Exynos4412 > - - samsung,exynos7-adc > - - samsung,s3c2410-adc > - - samsung,s3c2416-adc > - - samsung,s3c2440-adc > - - samsung,s3c2443-adc > - - samsung,s3c6410-adc > - - samsung,s5pv210-adc > + oneOf: > + - enum: > + - samsung,exynos-adc-v1 # Exynos5250 > + - samsung,exynos-adc-v2 > + - samsung,exynos3250-adc > + - samsung,exynos4212-adc # Exynos4212 and Exynos4412 > + - samsung,exynos7-adc > + - samsung,s3c2410-adc > + - samsung,s3c2416-adc > + - samsung,s3c2440-adc > + - samsung,s3c2443-adc > + - samsung,s3c6410-adc > + - samsung,s5pv210-adc > + - items: > + - enum: > + - samsung,exynos5433-adc > + - const: samsung,exynos7-adc > > reg: > maxItems: 1
