Hi, Alexandre seems to be okay with the current (merged) dt-binding, what do I do ? I can send a v3 for trivial-rtc.yaml that's not a problem for me but both of you seem to be disagree :) Regards, Romain Le jeu. 14 sept. 2023 à 10:28, Conor Dooley <conor.dooley@xxxxxxxxxxxxx> a écrit : > > On Thu, Sep 14, 2023 at 09:08:52AM +0200, Romain Perier wrote: > > Le mer. 13 sept. 2023 à 20:30, Conor Dooley <conor@xxxxxxxxxx> a écrit : > > > > > > On Wed, Sep 13, 2023 at 05:16:05PM +0200, Romain Perier wrote: > > > > Add YAML bindings for Mstar SSD202D RTC. > > > > > > > > Signed-off-by: Romain Perier <romain.perier@xxxxxxxxx> > > > > --- > > > > .../bindings/rtc/mstar,ssd202d-rtc.yaml | 35 +++++++++++++++++++ > > > > 1 file changed, 35 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/rtc/mstar,ssd202d-rtc.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/rtc/mstar,ssd202d-rtc.yaml b/Documentation/devicetree/bindings/rtc/mstar,ssd202d-rtc.yaml > > > > new file mode 100644 > > > > index 000000000000..4c1f22ef5a2c > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/rtc/mstar,ssd202d-rtc.yaml > > > > @@ -0,0 +1,35 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/rtc/mstar,ssd202d-rtc.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Mstar SSD202D Real Time Clock > > > > + > > > > +maintainers: > > > > + - Daniel Palmer <daniel@xxxxxxxx> > > > > + - Romain Perier <romain.perier@xxxxxxxxx> > > > > + > > > > +allOf: > > > > + - $ref: rtc.yaml# > > > > + > > > > +properties: > > > > + compatible: > > > > + enum: > > > > + - mstar,ssd202d-rtc > > > > + reg: > > > > + maxItems: 1 > > > > + > > > > +required: > > > > + - compatible > > > > + - reg > > > > > > > Hi, > > > > > So, this seems fine to me in isolation, but isn't this now the sort of > > > thing that can be documented in trivial-rtc.yaml? > > > Its only got compatible & reg, which seems to fit the bill for that. > > > > > > > With the current state, it might make sense. However, currently, the > > RTC hw block is mostly > > reverse-engineered, the driver is not complete yet, things like > > external irq or wakeup irq might arrive later (once we know how it is > > wired up and used). > > So the content of the dt-bindings might change and differ from a > > simple "compatible & reg" requirement. > > It's always possible to move from that to a fully fledged binding at a > later date. re: interrupts, trivial-rtc permits a single interrupt, so > it'd still be suitable if the device only has one. > > Thanks, > Conor.
