> On 30/10/2023 12:50, Antoniu Miclaus wrote: > > Document the Analog Devices MAX31335 device tree bindings. > > > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> > > --- > > .../devicetree/bindings/rtc/adi,max31335.yaml | 61 > +++++++++++++++++++ > > 1 file changed, 61 insertions(+) > > create mode 100644 > Documentation/devicetree/bindings/rtc/adi,max31335.yaml > > > > diff --git a/Documentation/devicetree/bindings/rtc/adi,max31335.yaml > b/Documentation/devicetree/bindings/rtc/adi,max31335.yaml > > new file mode 100644 > > index 000000000000..b84be0fa34ef > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/rtc/adi,max31335.yaml > > @@ -0,0 +1,61 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: > https://urldefense.com/v3/__http://devicetree.org/schemas/rtc/adi,max31 > 335.yaml*__;Iw!!A3Ni8CS0y2Y!8dEITWcTQ- > eZ_KG0TRlZ9ghWuDPnZwR1oR5OpGyvJkmAOxsFxDYI7rUqR- > U_KSQcGbkqxJ3glqBcJa_jjbukeVtyVSw-LCq3$ > > +$schema: https://urldefense.com/v3/__http://devicetree.org/meta- > schemas/core.yaml*__;Iw!!A3Ni8CS0y2Y!8dEITWcTQ- > eZ_KG0TRlZ9ghWuDPnZwR1oR5OpGyvJkmAOxsFxDYI7rUqR- > U_KSQcGbkqxJ3glqBcJa_jjbukeVtyVRI7679n$ > > + > > +title: Analog Devices MAX31335 RTC Device Tree Bindings > > It does not look like you tested the bindings, at least after quick > look. Please run `make dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > Maybe you need to update your dtschema and yamllint. Indeed I was using an older dtschema version locally and the dt_binding_check was not throwing any errors. will address the comments in the next version. > Although I wonder why there is no error report from the bot. > > Drop "Device Tree Bindings" > > > + > > +allOf: > > + - $ref: rtc.yaml# > > This goes after description. Several existing files have it in other > place, but if doing changes then well... > > > + > > +maintainers: > > + - Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> > > + > > +description: Analog Devices MAX31335 I2C RTC > > Drop or say something else than title. > > > > + > > +properties: > > + compatible: > > + const: adi,max31335 > > + > > + reg: > > + description: I2C address of the RTC > > Drop description, obvious. > > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + "#clock-cells": > > + description: > > + RTC can be used as a clock source through its clock output pin. > > + const: 0 > > + > > + trickle-resistor-ohms: > > + description: Selected resistor for trickle charger. > > + enum: [3000, 6000, 11000] > > default? Or missing property has other meaning... > > > + > > + trickle-diode-enable: true > > Where is it defined? You added it as it was a common property, so where > is the one definition? Maybe you wanted to use other property from > rtc.yaml which is deprecated, so obviously not... > > > + > > +required: > > + - compatible > > + - reg > > + > > Best regards, > Krzysztof
