Re: [PATCH] rtc: at91rm9200: annotate at91_rtc_remove with __exit again

Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx> · Fri, 20 Oct 2023 14:46:43 +0200

On 16/10/2023 at 06:18, alexandre.belloni@xxxxxxxxxxx wrote:
From: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>

Without __exit, having the driver as a builtin after dropping the __exit
annotation results in:

drivers/rtc/rtc-at91rm9200.c:561:13: warning: 'at91_rtc_remove' defined but not used [-Wunused-function]
      561 | static void at91_rtc_remove(struct platform_device *pdev)
          |             ^~~~~~~~~~~~~~~

Reported-by: kernel test robot <lkp@xxxxxxxxx>
Closes: https://lore.kernel.org/oe-kbuild-all/202310160705.vlElNOGb-lkp@xxxxxxxxx/
Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>

Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
Thanks Alexandre, best regards,
  Nicolas

---
  drivers/rtc/rtc-at91rm9200.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
index 3f5ff9867c02..c16fe711a0d9 100644
--- a/drivers/rtc/rtc-at91rm9200.c
+++ b/drivers/rtc/rtc-at91rm9200.c
@@ -558,7 +558,7 @@ static int __init at91_rtc_probe(struct platform_device *pdev)
  /*
   * Disable and remove the RTC driver
   */
-static void at91_rtc_remove(struct platform_device *pdev)
+static void __exit at91_rtc_remove(struct platform_device *pdev)
  {
         /* Disable all interrupts */
         at91_rtc_write_idr(AT91_RTC_ACKUPD | AT91_RTC_ALARM |
--
2.41.0









