On Mon, Oct 9, 2023 at 7:24 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > What 3 different purposes? The variable gets initialized 3 times with different (unrelated) values: 1. count old rtc->dev.groups 2. count grps 3. allocate new rtc->dev.groups This coding style is confusing and error prone. The code gets simpler with this patch, because the cognitive load of understanding a "count_attribute_groups()" call is lower than reading the "while" loop and figuring out why it's there. But I really wrote this patch because after making "rtc->dev.groups" const, I cannot any longer assign it to "groups", because that variable must remain non-const.
