On Tue, 03 Oct 2023 07:03:55 +0200, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@xxxxxxxxxx> > > Support for old NVMEM fixed cells was deprecated in favour of > "fixed-layout". It's still part of the nvmem.yaml though and may be > unknowingly used by new bindings added without much of analyze. > > To make it more difficult to accidentally support old syntax move its > binding to separated file with "deprecated" in its name. > > Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx> > --- > .../devicetree/bindings/mtd/mtd.yaml | 7 ++++- > .../bindings/mtd/partitions/nvmem-cells.yaml | 1 + > .../nvmem/amlogic,meson-gxbb-efuse.yaml | 1 + > .../bindings/nvmem/amlogic,meson6-efuse.yaml | 1 + > .../bindings/nvmem/apple,efuses.yaml | 1 + > .../devicetree/bindings/nvmem/imx-ocotp.yaml | 1 + > .../bindings/nvmem/mediatek,efuse.yaml | 1 + > .../nvmem/microchip,sama7g5-otpc.yaml | 1 + > .../devicetree/bindings/nvmem/mxs-ocotp.yaml | 1 + > .../nvmem/nvmem-deprecated-cells.yaml | 28 +++++++++++++++++++ > .../devicetree/bindings/nvmem/nvmem.yaml | 9 ------ > .../bindings/nvmem/qcom,qfprom.yaml | 1 + > .../bindings/nvmem/qcom,sec-qfprom.yaml | 1 + > .../bindings/nvmem/qcom,spmi-sdam.yaml | 1 + > .../bindings/nvmem/rockchip,otp.yaml | 1 + > .../bindings/nvmem/rockchip-efuse.yaml | 1 + > .../nvmem/socionext,uniphier-efuse.yaml | 1 + > .../bindings/nvmem/sunplus,sp7021-ocotp.yaml | 1 + > .../bindings/rtc/amlogic,meson6-rtc.yaml | 1 + > 19 files changed, 50 insertions(+), 10 deletions(-) > create mode 100644 Documentation/devicetree/bindings/nvmem/nvmem-deprecated-cells.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/rtc/amlogic,meson6-rtc.yaml: Error in referenced schema matching $id: http://devicetree.org/schemas/rtc/nvmem-deprecated-cells.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/rtc/amlogic,meson6-rtc.example.dtb: rtc@740: False schema does not allow {'compatible': ['amlogic,meson6-rtc'], 'reg': [[1856, 20]], 'interrupts': [[0, 72, 1]], 'clocks': [[4294967295]], 'vdd-supply': [[4294967295]], 'resets': [[4294967295]], '#address-cells': [[1]], '#size-cells': [[1]], 'mac@0': {'reg': [[0, 6]]}, '$nodename': ['rtc@740']} from schema $id: http://devicetree.org/schemas/rtc/amlogic,meson6-rtc.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/rtc/amlogic,meson6-rtc.example.dtb: rtc@740: Unevaluated properties are not allowed ('mac@0' was unexpected) from schema $id: http://devicetree.org/schemas/rtc/amlogic,meson6-rtc.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231003050355.1631-1-zajec5@xxxxxxxxx The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
