Re: [PATCH] rtc: m41t80: Simplify probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 28, 2023 at 11:13:29AM +0000, Biju Das wrote:
> > On Mon, Aug 28, 2023 at 10:27:37AM +0100, Biju Das wrote:

...

> > > +	m41t80_data->features = (unsigned long)i2c_get_match_data(client);
> > 
> > uintptr_t is more natural and de facto pattern for this. Why unsigned long
> > is here?
> 
> I just used the casting used for of_device_get_match_data.
> I will change it to uintptr_t, If there is no objection.
> 
> -		m41t80_data->features = (unsigned long)
> -			of_device_get_match_data(&client->dev);

Yes, but for new APIs the uintptr_t is natural (de facto).

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux