On Thu, 17 Aug 2023 17:10:38 +0100, Biju Das wrote: > The XTOSCB bit is not bit 0, but xtosb_val is either 0 or 1. If it is 1, > test will never succeed. Fix this issue by using double negation. > > While at it, remove unnecessary blank line from probe(). > > Applied, thanks! [1/1] rtc: isl1208: Fix incorrect logic in isl1208_set_xtoscb() commit: f45d32d2cd183c09b6c9aa8689a91d6f2760b557 Best regards, -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com