On Tue, 15 Aug 2023 15:16:41 -0700, Nathan Chancellor wrote: > After the switch to SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() and a subsequent > fix, stm32_rtc_{suspend,resume}() are unused when CONFIG_PM_SLEEP is not > set because SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() is a no-op in that > configuration: > > drivers/rtc/rtc-stm32.c:904:12: error: 'stm32_rtc_resume' defined but not used [-Werror=unused-function] > 904 | static int stm32_rtc_resume(struct device *dev) > | ^~~~~~~~~~~~~~~~ > drivers/rtc/rtc-stm32.c:894:12: error: 'stm32_rtc_suspend' defined but not used [-Werror=unused-function] > 894 | static int stm32_rtc_suspend(struct device *dev) > | ^~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > [...] Applied, thanks! [1/1] rtc: stm32: Use NOIRQ_SYSTEM_SLEEP_PM_OPS() commit: 2cf2a1acc6ebdffc6363de9156db8737f33c1803 Best regards, -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com