Hi Arnd, On Wed, Aug 9, 2023 at 8:26 PM Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Wed, Aug 9, 2023, at 18:36, kernel test robot wrote: > > If you fix the issue in a separate patch/commit (i.e. not just a new > > version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > | Closes: > > https://lore.kernel.org/oe-kbuild-all/202308100045.WeVD1ttk-lkp@xxxxxxxxx/ > > > > All warnings (new ones prefixed by >>): > > > >>> drivers/rtc/rtc-stm32.c:903:12: warning: 'stm32_rtc_resume' defined but not used [-Wunused-function] > > 903 | static int stm32_rtc_resume(struct device *dev) > > | ^~~~~~~~~~~~~~~~ > >>> drivers/rtc/rtc-stm32.c:893:12: warning: 'stm32_rtc_suspend' defined but not used [-Wunused-function] > > 893 | static int stm32_rtc_suspend(struct device *dev) > > | ^~~~~~~~~~~~~~~~~ > > This is the warning you get if my patch is applied but the > fb9a7e5360dc8 ("rtc: stm32: change PM callbacks to "_noirq()"") > commit is not. If that patch is applied, mine is needed to address > the other warning. Although both are now in linux-next, kisskb reported for m68k/allmodconfig: drivers/rtc/rtc-stm32.c:904:12: error: ‘stm32_rtc_resume’ defined but not used [-Werror=unused-function] 904 | static int stm32_rtc_resume(struct device *dev) | ^~~~~~~~~~~~~~~~ drivers/rtc/rtc-stm32.c:894:12: error: ‘stm32_rtc_suspend’ defined but not used [-Werror=unused-function] 894 | static int stm32_rtc_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~ Seems like you missed that the driver uses the old SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() instead of the new NOIRQ_SYSTEM_SLEEP_PM_OPS(). Patch sent. https://lore.kernel.org/r/20230816113326.1468435-1-geert@xxxxxxxxxxxxxx Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
