On Tue, Aug 1, 2023, at 19:35, Christoph Hellwig wrote: > au1xmmc is split somewhat awkwardly into the main mmc subsystem driver, > and callbacks in platform_data that sit under arch/mips/ and are > always built in. The latter than call mmc_detect_change through > symbol_get. Remove the use of symbol_get by requiring the driver > to be built in. In the future the interrupt handlers for card > insert/eject detection should probably be moved into the main driver, > and which point it can be built modular again. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Good idea. > of Alcor Micro PCI-E card reader > > config MMC_AU1X > - tristate "Alchemy AU1XX0 MMC Card Interface support" > + bool "Alchemy AU1XX0 MMC Card Interface support" > depends on MIPS_ALCHEMY > help This needs a depends on MMC=y otherwise you get a link failure with CONFIG_MMC=m and CONFIG_MMC_AU1X=y. With that fixed, Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>