On Mon, 31 Jul 2023 17:09:30 +0300
Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> This error path accidentally returns success. Return -EINVAL instead.
>
> Fixes: 420cc9e850db ("rtc: pcf2127: add support for multiple TS functions")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> From static analysis. Not tested.
>
> drivers/rtc/rtc-pcf2127.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c
> index 78141bb06ab0..988cad171174 100644
> --- a/drivers/rtc/rtc-pcf2127.c
> +++ b/drivers/rtc/rtc-pcf2127.c
> @@ -1060,7 +1060,7 @@ static int pcf2127_enable_ts(struct device *dev, int ts_id)
> if (pcf2127->cfg->ts[ts_id].gnd_detect_bit == 0) {
> dev_err(dev, "%s: tamper detection to GND configuration invalid\n",
> __func__);
> - return ret;
> + return -EINVAL;
> }
>
> /*
> --
> 2.39.2
Reviewed-by: Hugo Villeneuve <hugo@xxxxxxxxxxx>
