Hi Arnd, On Wed, Jul 19, 2023 at 3:41 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote: > From: Arnd Bergmann <arnd@xxxxxxxx> > > The added HAS_IOPORT dependency might not actually be necessary as Geert > points out, but the driver is also only used on one architecture. Sparc > is also a special case here since it converts port numbers into virtual > addresses rather than having them mapped into a particular part of the > __iomem address space, so the difference is actually not important here. > > Add a dependency on sparc, but allow compile-testing otherwise, to > make this clearer without anyone having to spend much time modernizing > the driver beyond that. > > Reported-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > Cc: David S. Miller <davem@xxxxxxxxxxxxx> > Link: https://lore.kernel.org/all/CAMuHMdWEx0F=fNei4Bz_JPkuvoaN-+zk08h0i8KnSi_VjO615g@xxxxxxxxxxxxxx/ > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> Thanks for your patch! > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -1195,7 +1195,7 @@ config RTC_DRV_MSM6242 > > config RTC_DRV_BQ4802 > tristate "TI BQ4802" > - depends on HAS_IOMEM && HAS_IOPORT > + depends on SPARC || (HAS_IOMEM && HAS_IOPORT && COMPILE_TEST) I'd rather just add a line "depends on SPARC || COMPILE_TEST", which is easier to parse. > help > If you say Y here you will get support for the TI > BQ4802 RTC chip. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
