Thu, Jun 01, 2023 at 08:34:02AM +0300, Nikita Shubin kirjoitti:
> - Find register range from the device tree.
It would be nice to be consistent with the commit messages of the same
semantics.
Nevertheless, LGTM,
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Signed-off-by: Nikita Shubin <nikita.shubin@xxxxxxxxxxx>
> ---
>
> Notes:
> v0 -> v1:
>
> - fixed headers
>
> drivers/rtc/rtc-ep93xx.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/rtc/rtc-ep93xx.c b/drivers/rtc/rtc-ep93xx.c
> index acae7f16808f..1fdd20d01560 100644
> --- a/drivers/rtc/rtc-ep93xx.c
> +++ b/drivers/rtc/rtc-ep93xx.c
> @@ -7,6 +7,7 @@
> */
>
> #include <linux/module.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/rtc.h>
> #include <linux/platform_device.h>
> #include <linux/io.h>
> @@ -148,9 +149,16 @@ static int ep93xx_rtc_probe(struct platform_device *pdev)
> return devm_rtc_register_device(ep93xx_rtc->rtc);
> }
>
> +static const struct of_device_id ep93xx_rtc_of_ids[] = {
> + { .compatible = "cirrus,ep9301-rtc" },
> + { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, ep93xx_rtc_of_ids);
> +
> static struct platform_driver ep93xx_rtc_driver = {
> .driver = {
> .name = "ep93xx-rtc",
> + .of_match_table = ep93xx_rtc_of_ids,
> },
> .probe = ep93xx_rtc_probe,
> };
> --
> 2.37.4
>
--
With Best Regards,
Andy Shevchenko
