> 2023年5月26日 13:06，Conor Dooley <conor.dooley@xxxxxxxxxxxxx> 写道： Hi all, [...] My two cents here as Loongson64 maintainer. > >>> To maintain compatibility with the existing devicetrees, should the old >>> "loongson,ls2x-rtc" be kept in the driver? >> >> No, It seems that wildcards in compatible are not allowed." >> loongson,ls2x-rtc" itself was part of this patch series at one time, >> but apparently it is not the right way to describe these chips. > > Right, but it has been merged - you are deleting the driver that supports > it after all - which means that any dtb with the old compatible will > stop working. It is perfectly fine to break DTB compatibility for Loongson64 systems As they *only* use builtin dtb. Bootloader will only pass machine type information and kernel will choose one dtb from it’s dtbs pool. Thanks - Jiaxun > I don't disagree with Krzysztof that having wildcard based compatibles > is bad, but I do not think that regressing rtc support for systems with > these old devicetrees is the right way to go either. > > Thanks, > Conor.
