On Tue, May 23, 2023 at 12:26 PM Esteban Blanc <eblanc@xxxxxxxxxxxx> wrote: > On Wed May 17, 2023 at 5:04 PM CEST, Andy Shevchenko wrote: > > On Wed, May 17, 2023 at 5:43 PM Esteban Blanc <eblanc@xxxxxxxxxxxx> wrote: ... > > Don't get me wrong, it's possible to have, but since it's unusual it > > needs to be well justified. In the change you proposed you have > > changed that, but I haven't seen where the new definition is used (in > > *.c files). > > Actualy it used in 2 places: > - In the switch case of `tps6594_gpio_regmap_xlate` > - In `tps6594_pinctrl_probe` when setting `reg_dir_out_base` > > I already sent a v5 with this change but I managed to fail my .config > and this driver was not compiled... and it is not compiling... I feel so > stupid. People are prone to making mistakes. :-) > I need to send a v6 now anyway. Should I convert all > TPS6594_REG_GPIO1_CONF to TPS6594_REG_GPIOX_CONF(0)? Again, if you want to leave that definition you need to well justify why it's so special that code needs it. Easiest way is to use the macro with 0 as an argument. -- With Best Regards, Andy Shevchenko
