Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v4 03/11] dt-bindings: rtc: isil,isl1208: Document > clock and clock-names properties > > Hi Biju, > > On Thu, May 18, 2023 at 1:37 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > wrote: > > As per the HW manual, XTOSCB bit setting is as follows > > > > If using an external clock signal, set the XTOSCB bit as 1 to disable > > the crystal oscillator. > > > > If using an external crystal, the XTOSCB bit needs to be set at 0 to > > enable the crystal oscillator. > > > > Document clock and clock-names properties. > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > --- > > v4: > > * New patch > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > > +++ b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > > @@ -25,6 +25,19 @@ properties: > > reg: > > maxItems: 1 > > > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + description: | > > + Use xin, if connected to an external crystal. > > + Use clkin, if connected to an external clock signal. > > + oneOf: > > + - items: > > + - const: xin > > + - items: > > + - const: clkin > > + > > I guess that oneOf scheme is equivalent to the simpler > > enum: > - xin > - clkin Agreed. Cheers, Biju
