On Mon, Apr 24, 2023, at 14:34, Nikita Shubin wrote:
> - get regs from device tree
>
> Signed-off-by: Nikita Shubin <nikita.shubin@xxxxxxxxxxx>
Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> +#ifdef CONFIG_OF
> +static const struct of_device_id m48t86_rtc_of_ids[] = {
> + { .compatible = "dallas,rtc-m48t86" },
> + { /* end of table */ },
> +};
> +MODULE_DEVICE_TABLE(of, m48t86_rtc_of_ids);
> +#endif
> +
> static struct platform_driver m48t86_rtc_platform_driver = {
> .driver = {
> .name = "rtc-m48t86",
> + .of_match_table = of_match_ptr(m48t86_rtc_of_ids),
> },
> .probe = m48t86_rtc_probe,
If you end up doing another revision, I'd suggest you drop the
of_match_ptr() and the #ifdef: there is no point in saving a
few bytes of space for non-DT kernel builds if both the machines
that use this device always rquire CONFIG_OF to be enabled.
Arnd
