On 13/04/2023 09:57, Binbin Zhou wrote: > The LS2X RTC alarm depends on the associated registers in a separate > power management domain. > > In order to define the PM domain addresses of the different chips, a > more detailed description of compatible is required. This does not match your diff at all. > > Signed-off-by: Binbin Zhou <zhoubinbin@xxxxxxxxxxx> > --- > Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml > index a3603e638c37..2928811b83a0 100644 > --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml > +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml > @@ -47,8 +47,11 @@ properties: > - isil,isl1218 > # Intersil ISL12022 Real-time Clock > - isil,isl12022 > - # Loongson-2K Socs/LS7A bridge Real-time Clock > - - loongson,ls2x-rtc Why removing it? > + # Loongson LS7A bridge Real-time Clock > + - loongson,ls7a-rtc > + # Loongson-2K Socs Real-time Clock > + - loongson,ls2k0500-rtc > + - loongson,ls2k1000-rtc That's even more surprising... I don't understand what you are doing here at all. Best regards, Krzysztof