On Sat, Mar 04, 2023 at 02:30:05PM +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
Thanks,
Conor.
> ---
> drivers/rtc/rtc-mpfs.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/rtc/rtc-mpfs.c b/drivers/rtc/rtc-mpfs.c
> index 2a479d44f198..5b96a6d39210 100644
> --- a/drivers/rtc/rtc-mpfs.c
> +++ b/drivers/rtc/rtc-mpfs.c
> @@ -274,11 +274,9 @@ static int mpfs_rtc_probe(struct platform_device *pdev)
> return devm_rtc_register_device(rtcdev->rtc);
> }
>
> -static int mpfs_rtc_remove(struct platform_device *pdev)
> +static void mpfs_rtc_remove(struct platform_device *pdev)
> {
> dev_pm_clear_wake_irq(&pdev->dev);
> -
> - return 0;
> }
>
> static const struct of_device_id mpfs_rtc_of_match[] = {
> @@ -290,7 +288,7 @@ MODULE_DEVICE_TABLE(of, mpfs_rtc_of_match);
>
> static struct platform_driver mpfs_rtc_driver = {
> .probe = mpfs_rtc_probe,
> - .remove = mpfs_rtc_remove,
> + .remove_new = mpfs_rtc_remove,
> .driver = {
> .name = "mpfs_rtc",
> .of_match_table = mpfs_rtc_of_match,
> --
> 2.39.1
>
Attachment:
signature.asc
Description: PGP signature
