On Thu, 2023-02-02 at 12:24 +0100, Krzysztof Kozlowski wrote:
> On 31/01/2023 19:30, David Virag wrote:
> > The S5M8751 and S5M8763 PMIC chips have no corresponding compatible
> > values, so since board file support was removed for this driver,
> > there
> > is no way to specify these PMICs as present in boards anymore.
> > Remove leftovers of these chips since it's dead code.
> >
> > Signed-off-by: David Virag <virag.david003@xxxxxxxxx>
> > ---
>
> Thank you for your patch. There is something to discuss/improve.
>
> > int sec_irq_init(struct sec_pmic_dev *sec_pmic)
> > {
> > int ret = 0;
> > @@ -448,9 +362,6 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic)
> > }
> >
> > switch (type) {
> > - case S5M8763X:
> > - sec_irq_chip = &s5m8763_irq_chip;
> > - break;
> > case S5M8767X:
> > sec_irq_chip = &s5m8767_irq_chip;
> > break;
> > diff --git a/include/linux/mfd/samsung/core.h
> > b/include/linux/mfd/samsung/core.h
> > index f92fe090473d..07aae649a86f 100644
> > --- a/include/linux/mfd/samsung/core.h
> > +++ b/include/linux/mfd/samsung/core.h
> > @@ -36,7 +36,6 @@
> > struct gpio_desc;
> >
> > enum sec_device_type {
> > - S5M8751X,
> > S5M8763X,
>
> Drop also S5M8763X
Dropping it in the first patch would lead to build errors in the RTC
driver, so I do it in the second patch, but I see that you already
realized this in the 2nd reply.
>
> > S5M8767X,
> > S2MPA01,
> > diff --git a/include/linux/mfd/samsung/s5m8763.h
> > b/include/linux/mfd/samsung/s5m8763.h
> > deleted file mode 100644
>
>
> Best regards,
> Krzysztof
>
Best regards,
David
