On 02.02.23 10:10, Krzysztof Kozlowski wrote: > On 01/02/2023 15:34, Frieder Schrempf wrote: >> From: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx> >> >> The RV3028 driver uses properties that are not covered by the >> trivial-rtc bindings. Use custom bindings for it. >> >> Signed-off-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx> >> --- >> .../bindings/rtc/microcrystal,rv3028.yaml | 56 +++++++++++++++++++ >> .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 - >> 2 files changed, 56 insertions(+), 2 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml >> >> diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml >> new file mode 100644 >> index 000000000000..4667ba86fd0c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml >> @@ -0,0 +1,56 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: https://eur04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Frtc%2Fmicrocrystal%2Crv3028.yaml%23&data=05%7C01%7Cfrieder.schrempf%40kontron.de%7Ca99c626bce484657aee508db04fd470f%7C8c9d3c973fd941c8a2b1646f3942daf1%7C0%7C0%7C638109258107205830%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=z8nsgRaxC3AcIoXteA7Xj7EpCKrA%2FkRPyrYeS1fig8I%3D&reserved=0 >> +$schema: https://eur04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7Cfrieder.schrempf%40kontron.de%7Ca99c626bce484657aee508db04fd470f%7C8c9d3c973fd941c8a2b1646f3942daf1%7C0%7C0%7C638109258107205830%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=1RPGw%2FEf7UUNrJZPAHDw7BHnuroLg1oVR4xLq2%2FgIHU%3D&reserved=0 >> + >> +title: Microchip RV-3028 RTC >> + >> +allOf: >> + - $ref: "rtc.yaml#" > > Drop quotes > >> + >> +maintainers: >> + - Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> >> + >> +properties: >> + compatible: >> + const: microcrystal,rv3028 >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + start-year: true > > This should be dropped as well and then... > >> + >> + trickle-resistor-ohms: >> + enum: >> + - 3000 >> + - 5000 >> + - 9000 >> + - 15000 >> + >> +required: >> + - compatible >> + - reg >> + >> +additionalProperties: false > > ...switch to unevaluatedProperties: false > >> + >> +examples: >> + - | >> + #include <dt-bindings/interrupt-controller/irq.h> >> + i2c { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + rtc@51 { > > Rob's pointed missing testing. > > But more important - please rebase your patches on current tree. Looks > like all the changes are already done... Oops, I need to remember to check patchwork/linux-next. Thanks anyway!
