On Fri, Jan 13, 2023 at 04:18:26PM +0000, Wadim Egorov wrote: > Am 11.01.23 um 19:51 schrieb Rob Herring: > > On Wed, Jan 11, 2023 at 12:47 PM Rob Herring <robh@xxxxxxxxxx> wrote: > >> > >> On Wed, 11 Jan 2023 17:34:03 +0100, Wadim Egorov wrote: > >>> Convert the PCA9532 LED dimmer to dtschema. > >>> While at it, also update and the the example to match > >>> recommended node names and the link to the product datasheet. > >>> > >>> Signed-off-by: Wadim Egorov <w.egorov@xxxxxxxxx> > >>> --- > >>> v2: > >>> - Rename yaml file to match compatibles, nxp,pca953x.yaml > >>> - Remove Jacek Anaszewski from maintainers list > >>> - Remove color labels in example > >>> - Restore labels/default-states from original example > >>> - Drop reg description > >>> - Add unevaluatedProperties to patternProperties scope > >>> - Update description of type property & set default to 0 > >>> - Fix indentation in example > >>> --- > >>> .../devicetree/bindings/leds/leds-pca9532.txt | 49 ----------- > >>> .../devicetree/bindings/leds/nxp,pca953x.yaml | 85 +++++++++++++++++++ > >>> 2 files changed, 85 insertions(+), 49 deletions(-) > >>> delete mode 100644 Documentation/devicetree/bindings/leds/leds-pca9532.txt > >>> create mode 100644 Documentation/devicetree/bindings/leds/nxp,pca953x.yaml > >>> > >> Running 'make dtbs_check' with the schema in this patch gives the > >> following warnings. Consider if they are expected or the schema is > >> incorrect. These may not be new warnings. > >> > >> Note that it is not yet a requirement to have 0 warnings for dtbs_check. > >> This will change in the future. > >> > >> Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230111163404.3526248-1-w.egorov@xxxxxxxxx > >> > >> > >> leddimmer@62: 'led1', 'led2', 'led3', 'led4' do not match any of the regexes: '^led-[0-9a-z]+$', 'pinctrl-[0-9]+' > >> arch/arm/boot/dts/rk3288-phycore-rdk.dtb > >> > >> leds@62: 'led1', 'led2', 'led3' do not match any of the regexes: '^led-[0-9a-z]+$', 'pinctrl-[0-9]+' > >> arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb > >> > >> pca9530@61: 'tft-panel@0' does not match any of the regexes: '^led-[0-9a-z]+$', 'pinctrl-[0-9]+' > >> arch/arm/boot/dts/am335x-pdu001.dtb > > How do I comply with the LED label warnings? > I am not sure about the proper convention. I was assuming led-<name> is correct. > The first two warnings can be fixed by dropping the '-' in the regex. > But I don't see how the last warning should comply with a proper LED node name. > Or can this be ignored? Those dts files should be fixed, not the schema. You don't have to do that. Rob
