On 23/11/2022 06:35, Matt Ranostay wrote: > Add documentation for the TPS6594 PMIC including its RTC and GPIO > functionalities. Back in September I asked to use get_maintainers.pl to CC people. Can you please tell me, why you still prefer not to use it's output and instead use a bit different email addresses? How many times same feedback should be given? > > Signed-off-by: Matt Ranostay <mranostay@xxxxxx> > --- > .../devicetree/bindings/mfd/ti,tps6594.yaml | 69 +++++++++++++++++++ > 1 file changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/ti,tps6594.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/ti,tps6594.yaml b/Documentation/devicetree/bindings/mfd/ti,tps6594.yaml > new file mode 100644 > index 000000000000..0de0db87dbf7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/ti,tps6594.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/ti,tps6594.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TPS6594 Power Management Integrated Circuit (PMIC) > + > +description: | > + TPS6594 Power Management Integrated Circuit (PMIC) > + https://www.ti.com/lit/ds/symlink/tps6594-q1.pdf > + > +maintainers: > + - Keerthy <j-keerthy@xxxxxx> > + > +properties: > + compatible: > + enum: > + - ti,tps6594 > + > + reg: > + const: 0x48 > + > + ti,system-power-controller: > + type: boolean > + description: PMIC is controlling the system power. > + > + rtc: > + type: object > + $ref: /schemas/rtc/rtc.yaml# > + unevaluatedProperties: false > + properties: > + compatible: > + const: ti,tps6594-rtc > + > + gpio: > + type: object > + unevaluatedProperties: false > + properties: > + compatible: > + const: ti,tps6594-gpio > + > +additionalProperties: false > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + i2c0 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmic: pmic@48 { > + compatible = "ti,tps6594"; > + reg = <0x48>; > + > + rtc { > + compatible = "ti,tps6594-rtc"; No resources? No properties? Usually such nodes are not useful at all. Rob pointed this some times in different cases, but I don't remember if we resolved it here. > + }; > + > + gpio { > + compatible = "ti,tps6594-gpio"; Same question. > + }; > + }; > + }; > + > +... Best regards, Krzysztof
