This series has the remainder of https://lore.kernel.org/all/20220426071056.1187235-1-s.hauer@xxxxxxxxxxxxxx/ which was partly applied. Alexandre, Last time this series was send you asked if this series fixes a problem we've really seen to which Ahmad answered: > The kernel message > > rtc rtc0: invalid alarm value: 2020-3-27 7:82:0 > > listed in the commit message is something I actually ran into. There > was no v2f set then. The customer has also variously observed bit flips > independently of v2f: During EMC testing, electrostatic discharge at developer > desks and even in the field: Suspected causes were lightning strikes in the > vicinity and the switching of larger inductive loads. > They're very paranoid of logging invalid timestamps, so we'll keep the patch > anyhow at our side, but I think it is generally useful as well: If we can't > set an invalid alarm time by normal means, but read back an invalid time, > something may have corrupted other memory, so treating it as a v2f is sensible. There was no answer to this. I would be glad if you could take this series. I would understand though if you say that this problem is too esoteric to fix it upstream, we would keep the patches locally then. Please just say so, it would help me to get the problem from my desk ;) Thanks, Sascha Ahman Fatoum (1): include/linux/bcd.h: provide bcd_is_valid() helper Sascha Hauer (1): rtc: rv8803: invalidate date/time if alarm time is invalid drivers/rtc/rtc-rv8803.c | 45 +++++++++++++++++++++++++++++++++------- include/linux/bcd.h | 4 ++++ 2 files changed, 42 insertions(+), 7 deletions(-) -- 2.30.2
