On Sun, Nov 20, 2022, at 01:39, Randy Dunlap wrote:
> Prevent a printk format warning by using %pap, which is designed for
> this purpose and can handle any size of resource_size_t.
>
> ../drivers/rtc/rtc-sunplus.c: In function 'sp_rtc_probe':
> ../drivers/rtc/rtc-sunplus.c:243:33: warning: format '%x' expects
> argument of type 'unsigned int', but argument 4 has type
> 'resource_size_t' {aka 'long long unsigned int'} [-Wformat=]
> 243 | dev_dbg(&plat_dev->dev, "res = 0x%x, reg_base =
> 0x%lx\n",
>
> Fixes: 0aa94eea8d95 ("ARM: sunplus: Add initial support for Sunplus SP7021 SoC")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Qin Jian <qinjian@xxxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Vincent Shih <vincent.sunplus@xxxxxxxxx>
> Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
> Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> Cc: linux-rtc@xxxxxxxxxxxxxxx
Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> if (IS_ERR(sp_rtc->reg_base))
> return dev_err_probe(&plat_dev->dev, PTR_ERR(sp_rtc->reg_base),
> "%s devm_ioremap_resource fail\n", RTC_REG_NAME);
> - dev_dbg(&plat_dev->dev, "res = 0x%x, reg_base = 0x%lx\n",
> - sp_rtc->res->start, (unsigned long)sp_rtc->reg_base);
> + dev_dbg(&plat_dev->dev, "res = 0x%pap, reg_base = 0x%lx\n",
> + &sp_rtc->res->start, (unsigned long)sp_rtc->reg_base);
>
I would have picked %pr to print the resource, but hsi works as well.
Arnd
