On Thu, Nov 10, 2022 at 11:12 AM Matt Ranostay <mranostay@xxxxxx> wrote: > On Wed, Nov 09, 2022 at 10:59:08AM +0100, Linus Walleij wrote: > > On Wed, Nov 9, 2022 at 7:56 AM Matt Ranostay <mranostay@xxxxxx> wrote: > > > > > Add support for TPS6594X PMICs GPIO interface that has 11 that can be > > > configured as input or outputs. > > > > > > Tested-by: Keerthy <j-keerthy@xxxxxx> > > > Signed-off-by: Matt Ranostay <mranostay@xxxxxx> > > > > (...) > > > +config GPIO_TPS6594X > > > + tristate "TI TPS6594X GPIO driver" > > > + depends on MFD_TPS6594X > > > + help > > > + Select this option to enable GPIO driver for the TPS6954X > > > + PMIC chip family. There are 11 GPIOs that can be configured. > > > > select GPIO_REGMAP > > > > This driver is an archetypical example of a driver that can make great > > use of GPIO_REGMAP helpers, so rewrite it to use them. > > Look in drivers/gpio/gpio-sl28cpld.c for an example. > > Linus, > > Those helpers look great for this usecase on the surface but however I think there could be some issues. > For GPIO direction it isn't configured by a bitmap on a register(s) but by a bit on a range of > registers (with a register for each GPIOx). > > For set/get values the gpio helper would work though. Isn't is possible to just use parts of the GPIO_REGMAP helpers? I thought it's designed like such. Michael Walle will know what to do with your usecase, and whether to use it or not, let's page him! Yours, Linus Walleij
