On Mon, Nov 7, 2022 at 10:22 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Mon, Nov 07, 2022 at 09:01:50PM +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > > > The names of rtc_wake_setup() and cmos_wake_setup() don't indicate > > that these functions are ACPI-related, which is the case, and the > > former doesn't really reflect the role of the function. > > > > Rename them to acpi_rtc_event_setup() and cmos_acpi_wake_setup(), > > respectively, to address this shortcoming. > > Hmm... I'm not sure I understand why in one case acpi is a prefix and > in the other is kinda mid-suffix? Because the former installs an ACPI RTC fixed event handler and the latter populates the cmos_rtc data structure in the ACPI case. Maybe it would be better to call the latter cmos_wake_setup_acpi().
