On Fri, Oct 28, 2022 at 05:54:00PM -0700, Guenter Roeck wrote: > Drop error messages in cros_ec_rtc_get() and cros_ec_rtc_set() since the > calling code also logs an error and to avoid spurious error messages if > setting the alarm ultimately succeeds. It only retries for cros_ec_rtc_set(). cros_ec_rtc_get() doesn't emit spurious error messages. cros_ec_rtc_get() could preserve the error log; cros_ec_rtc_set() could change from using dev_err() to dev_warn() since cros_ec_rtc_set_alarm() calls dev_err() if cros_ec_rtc_set() fails. But this is quite nitpick so anyway. > Cc: Brian Norris <briannorris@xxxxxxxxxxxx> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>
