On 11/08/2022 12:14, zhiyong.tao wrote: > On Thu, 2022-08-11 at 11:58 +0300, Krzysztof Kozlowski wrote: >> On 11/08/2022 11:42, zhiyong.tao wrote: >>>> >>>>> >>>>> Signed-off-by: zhiyong tao <zhiyong.tao@xxxxxxxxxxx> >>>>> --- >>>>> .../regulator/mediatek,mt6366-regulator.yaml | 375 >>>>> ++++++++++++++++++ >>>>> 1 file changed, 375 insertions(+) >>>> >>>> Subject does not match subsystem. >>> >>> Hi Krzysztof, >>> >>> Do you mean that we should change the title like this: >>> regulator: dt-bindings: mediatek: add mt6366 regulator document >>> is it right? >> >> Yes. And remove redundant pieces so for example: >> >> regulator: dt-bindings: mediatek: add mt6366 >> or: >> regulator: dt-bindings: add mediatek,mt6366 > ==> > Thanks for your suggestion, we will fix it in next verison. >> >> >> (...) >> >>>>> + patternProperties: >>>>> + "^buck- >>>>> v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": >>>>> + type: object >>>>> + $ref: "regulator.yaml#" >>>> >>>> No need for quotes. >>> >>> ==> >>> We will remove the line "$ref: "regulator.yaml#"" in next verison, >>> is >>> it right? >> >> No, it is not. Why do you want to remove it? > ==> > We don't understand "No need for quotes."which means. > Do you mean that we should remove the quotation marks. > We will change it like this:$ref: regulator.yaml# > is it right? Yes, remove the quotation marks. You wanted to remove entire line which is not correct. $ref should stay. Best regards, Krzysztof
