On 21/07/2022 15:33, Alexander Stein wrote:
> Convert the NXP PCF85063 RTC binding to DT schema format.
>
> Add 'interrupts' and 'wakeup-source' as this device has an interrupt
> which was not documented, but is in use.
> 'clock-output-names' and '#clock-cells' are added as well, those were
> probably missed when adding clkout support in commit 8c229ab6048b
> ("rtc: pcf85063: Add pcf85063 clkout control to common clock framework")
Thanks for adding it here, this sounds fine but brought my attention to
interrupts and quartz-load. It seems that only rv8263 supports
interrupts. In the same time rv8263 work only with 7000
quartz-load-femtofarads.
If that's correct, you need to put "allOf" after "required" and inside
"if:then:" restricting it. For rv8263 interrupts:true and quartz as
const 7000, for else: interrupts:false.
>
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> ---
> Krzysztof, thanks for your review.
>
> Changes in v2:
> * Sorted compatible list
> * Mentioned new #clock-cells and clock-output-names properties in commit message
> * Removed 'interrupt-names', not needed/used anyway
> * Fixed quartz-load-femtofarads defintion/description
>
> .../devicetree/bindings/rtc/nxp,pcf85063.txt | 32 --------
> .../devicetree/bindings/rtc/nxp,pcf85063.yaml | 73 +++++++++++++++++++
> 2 files changed, 73 insertions(+), 32 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf85063.txt
> create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
>
Best regards,
Krzysztof
