[AMD Official Use Only - General] Hi, > -----Original Message----- > From: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> > Sent: Friday, June 10, 2022 5:34 PM > To: Srinivas Neeli <srinivas.neeli@xxxxxxxxxx> > Cc: a.zummo@xxxxxxxxxxxx; robh+dt@xxxxxxxxxx; > krzysztof.kozlowski+dt@xxxxxxxxxx; michal.simek@xxxxxxxxxx; > sgoud@xxxxxxxxxx; shubhraj@xxxxxxxxxx; Neeli, Srinivas > <srinivas.neeli@xxxxxxx>; neelisrinivas18@xxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-rtc@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; git@xxxxxxxxxx > Subject: Re: [PATCH V7 3/3] rtc: zynqmp: Updated calibration value > > On 10/06/2022 17:07:09+0530, Srinivas Neeli wrote: > > As per RTC spec default calibration value is 0x7FFF. > > > > Having that as a second patch breaks the calculation in your previous patch, > really, this should just be a single patch. Can I swap 3/3 and 2/3, Will that be fine ?. > > > Signed-off-by: Srinivas Neeli <srinivas.neeli@xxxxxxxxxx> > > --- > > Changes in V7: > > -New patch > > -TRM not updated yet, Internal design document contains 0x7FFF as > > default value. TRM Will update in next release. > > --- > > drivers/rtc/rtc-zynqmp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/rtc/rtc-zynqmp.c b/drivers/rtc/rtc-zynqmp.c index > > 39b23f88ee26..1dd389b891fe 100644 > > --- a/drivers/rtc/rtc-zynqmp.c > > +++ b/drivers/rtc/rtc-zynqmp.c > > @@ -37,7 +37,7 @@ > > #define RTC_OSC_EN BIT(24) > > #define RTC_BATT_EN BIT(31) > > > > -#define RTC_CALIB_DEF 0x198233 > > +#define RTC_CALIB_DEF 0x7FFF > > #define RTC_CALIB_MASK 0x1FFFFF > > #define RTC_ALRM_MASK BIT(1) > > #define RTC_MSEC 1000 > > -- > > 2.25.1 > > > > -- > Alexandre Belloni, co-owner and COO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
