On Fri, 20 May 2022 10:22:21 +0200, Miquel Raynal wrote: > In the ->set_offset() callback, the 'val' variable is used for two > different purposes at the same time, which is oviously wrong: > - It contains the intermediate value of the SUBU register that must be > written at the end of ->set_offset(). > - It is used in the middle of the above calculations to poll the CTL2 > register for a specific value. > > [...] Applied, thanks! [1/1] rtc: rzn1: Avoid mixing variables commit: 64d69b5daf6fe9b86236d34e57ba8ebf7d84f245 Best regards, -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com