Zhang Rui <rui.zhang@xxxxxxxxx> writes: > Hi, Kalle, > > thanks for the quick response. > > On Thu, 2022-05-05 at 07:38 +0300, Kalle Valo wrote: >> Zhang Rui <rui.zhang@xxxxxxxxx> writes: >> >> > Remove the useless debug message for unsupported PM event because >> > it is >> > noop in current code, and it gives a warning when a new event is >> > introduced, which it doesn't care. >> >> It's a debug message, not a warning, and only visible when debug >> messages are enabled. Why do you want to remove it? > > I'm concerning that people will report problems when they see new > messages which never shows up previously. > > Deleting or keeping this message are both okay to me. But patch 6/7 > indeed introduces a change to this piece of code and it's better for > you to be aware of it before people starts to complain. > >> >> > Signed-off-by: Zhang Rui <rui.zhang@xxxxxxxxx> >> > Tested-by: Sumeet Pawnikar <sumeet.r.pawnikar@xxxxxxxxx> >> >> Is this really tested on a wil6210 device? Not that it matters, just >> surprised to see a Tested-by for a wil6210 patch. It's not really >> common >> hardware. > > No, we just tested the whole patch series on a Dell 9360 laptop, and a > series of internal test machines. I didn't check if any of them has > this device or not. Maybe I should remove the tested by in this case? I think it's best to drop this wil6210 patch. The driver is orphaned anyway and if anyone complains, they will do that to me :) -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
