On Thu, 17 Feb 2022 17:59:21 -0600
Rob Herring <robh@xxxxxxxxxx> wrote:
> On Fri, Feb 11, 2022 at 03:50:29PM -0500, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> >
> > Add support for new NXP RTC PCF2131.
> >
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> > ---
> > .../devicetree/bindings/rtc/nxp,pcf2127.yaml | 19 ++++++++++++++++++-
> > 1 file changed, 18 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > index cde7b1675ead..57eb0a58afa3 100644
> > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > @@ -14,7 +14,9 @@ maintainers:
> >
> > properties:
> > compatible:
> > - const: nxp,pcf2127
> > + enum:
> > + - nxp,pcf2127
> > + - nxp,pcf2131
> >
> > reg:
> > maxItems: 1
> > @@ -48,4 +50,19 @@ examples:
> > };
> > };
> >
> > + - |
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + rtc@53 {
> > + compatible = "nxp,pcf2131";
> > + reg = <0x53>;
> > + pinctrl-0 = <&rtc_nint_pins>;
> > + interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>;
> > + reset-source;
> > + };
> > + };
>
> Just a new compatible doesn't really justify another example.
>
> Rob
Hi,
yes, now that I've remove the specific properties, the example can be removed.
Hugo.
