On 26/01/2022 18:14, Laurent Vivier wrote: > Le 26/01/2022 à 12:55, Daniel Lezcano a écrit : >> >> Hi Laurent, >> > > Hi Daniel, > >> On 21/01/2022 21:07, Laurent Vivier wrote: >>> Add a clocksource based on the goldfish-rtc device. >> >> As a first submission, please provide a more detailed description of the >> timer. > > ok. > > The timer uses in fact the goldifsh RTC clock so I supposed refering to > drivers/rtc/rtc-goldfish.c could give the missing pieces of information [ ... ] > I agree for irq, but res is passed to request_resource() and I think it > is added to a linked tree, so I'm not sure it can be local to the function. > > Do you mean a "static" declaration in the function? I missed request_resource() was adding the resource in a list, thus the parameter must not be freed. So discard the comment for 'res'. [ ... ] -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
