From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
If reading CLKOUT register fails, the probe operation will be aborted
without a meaningful error message.
Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
---
drivers/rtc/rtc-pcf2127.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c
index cea10fdbb010..3d1f57e54372 100644
--- a/drivers/rtc/rtc-pcf2127.c
+++ b/drivers/rtc/rtc-pcf2127.c
@@ -709,8 +709,10 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap,
}
ret = regmap_read(pcf2127->regmap, PCF2127_REG_CLKOUT, &val);
- if (ret < 0)
+ if (ret < 0) {
+ dev_err(dev, "reading CLKOUT register failed\n");
return ret;
+ }
if (!(val & PCF2127_BIT_CLKOUT_OTPR)) {
ret = regmap_set_bits(pcf2127->regmap, PCF2127_REG_CLKOUT,
--
2.30.2
